Make ckan accessible, part 1 #5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weirdly there is some color difference between python 2 and 3, might be a bug somewhere. |
Zharktas
force-pushed
the
make_ckan_accessible
branch
from
8612805
to
778e6c4
Compare
|
Great work. No problems detected, so i'm merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ckan/ideas#238
Proposed fixes:
Adds cypress-axe plugin to cypress which runs a11y axe validation tool on the pages tested with cypress.
Adds cypress tests starting with the basic pages and moving on to more complex user interactions while fixing validation issues which are reported.
As I am not accessibility professional, this will mostly only cover issues which can be discovered with automated tools. It would require professional to fix the more complex ones.
This is an ongoing effort to make ckan accessible, I'll try to finish as much as I can before 2.9 release, but most likely it will not cover everything.
Automated tests only cover pages in the main nav, as individual datasets and organizations would require pre-populating them in the database for cypress tests.
Forms are also not covered by this PR, they affect far less in the user base anyway, so those would be fixed later.
There are user visible changes, as some colors are changed to make them have enough contrast.
This PR also updates Cypress to 4.8.0.
Features:
Please [X] all the boxes above that apply