config-tool can be used with incomplete config file #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5568
Right now a config file will be loaded during CLI initialization as long as it's available, even if it's not required(
generate extension,config-tool). This may cause issues if the config file contains options that prevent the initialization of CKAN(plugin, that is not installed yet; incorrect DB URL). The biggest problem here, those incorrect values cannot be changed even withconfig-tool, because of fail during app initialization.This PR makes CLI completely ignore the config file for the given subset of commands(
ckan.cli:_no_config_commandsvariable).