Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#25 Changes "Refresh" to "Reharvest" and adds confirmation dialog #26

Merged
merged 3 commits into from
Mar 21, 2013

Conversation

johnmartin
Copy link
Contributor

Fixes #25

@ghost ghost assigned amercader Mar 21, 2013
@shevski
Copy link

shevski commented Mar 21, 2013

Hey @amercader can you take a look? Want this in the package today

{% else %}
<li>{{ h.nav_named_link(_('Refresh'), '{0}_refresh'.format(c.dataset_type), id=source.id, class_='btn', icon='refresh')}}</li>
{% set locale = h.dump_json({'content': _('This will re-run the harvesting for this source. Any updates at the source will overwrite the local datasets. Large collections may take a couple of days to finish harvesting. Please confirm you would like us to start reharvesting.')}) %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large collections may take a couple of days to finish harvesting.

This is not relevant to a default ckanext-harvest install and will create a lot of confusion, can we drop it here and add a custom admin_base.html file in ckanext-geodatagov with the message you prefer there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amercader Sure. So we have the message like: (for ckanext-harvest)

This will re-run the harvesting for this source. Any updates at the source will overwrite the local datasets. Please confirm you would like to start reharvesting.

And then on ckanext-geodatagov:

This will re-run the harvesting for this source. Any updates at the source will overwrite the local datasets. Large collections may take a couple of days to finish harvesting. Please confirm you would like to start reharvesting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

@johnmartin
Copy link
Contributor Author

@amercader OK, there you go. I'll update https://github.com/okfn/ckanext-geodatagov with an issue/pull request in a bit.

@amercader amercader merged commit 4d0dd9a into release-v2.0 Mar 21, 2013
amercader pushed a commit that referenced this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants