Skip to content
This repository has been archived by the owner on Sep 11, 2019. It is now read-only.

SDK Builder messes up HTML code #1

Closed
wwalc opened this issue Jun 5, 2014 · 2 comments
Closed

SDK Builder messes up HTML code #1

wwalc opened this issue Jun 5, 2014 · 2 comments
Assignees
Labels

Comments

@wwalc
Copy link
Member

wwalc commented Jun 5, 2014

SDK Builder is enforcing invalid entities.

Original code:

                CKEDITOR.replace( 'editor1', {
                    uiColor: '#CCEAEE'
                });

Release version:

                CKEDITOR.replace( 'editor1', {
                    uiColor: '#CCEAEE'
                });

Original:

Copyright &copy; 2003-2014, <a class="samples" href="http://cksource.com/">CKSource</a> (...)

Release version:

Copyright &#xA9; 2003-2014, (....)

The altered <title> tag is messed up as well:

CKEditor SDK &#xBB; Samples &#xBB; UI Color
@wwalc wwalc added the bug label Jun 5, 2014
@adelura adelura self-assigned this Jun 5, 2014
@adelura
Copy link
Contributor

adelura commented Jun 5, 2014

This issue is related to cheeriojs/cheerio#496, which is fixed right now. I think we are gonna wait for next release. Also related to: cheeriojs/cheerio#501 and cheeriojs/cheerio#503

adelura added a commit that referenced this issue Jun 6, 2014
@adelura
Copy link
Contributor

adelura commented Jun 13, 2014

Fixed with cheerio 0.17.0 release. Added new version dependency in package.json.

@adelura adelura closed this as completed Jun 13, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants