Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit empty anchor tags #476

Closed
benphelps opened this issue Jun 6, 2017 · 2 comments
Closed

Cannot edit empty anchor tags #476

benphelps opened this issue Jun 6, 2017 · 2 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@benphelps
Copy link

Are you reporting a feature or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Click on the anchor button with no text selected
  2. Set the name of the anchor tag, the empty anchor tag is created
  3. Attempt to edit the added anchor tag, either via right click or by clicking the anchor button with the anchor tag selected

You can observe this here as well: http://sdk.ckeditor.com/samples/classic.html

Expected result

You should be able to edit the anchor tag.

Actual result

You cannot edit the anchor tag.

Other details

  • Browser: Chrome 59
  • OS: OS X 10.12.5
  • CKEditor version: 4.7 / 4.7.1
  • Installed CKEditor plugins: The default "Full" package, nothing else.
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Jun 9, 2017
@mlewand
Copy link
Contributor

mlewand commented Jun 9, 2017

Thanks for the report. This is a regression introduced in 4.7.0, most likely it was introduced when adapting link plugin to multi range support.

It seems to be a cross browser, as I also tested also Edge and it's the same thing there.

In addition to what was reported by OP I can see that it's no longer possible to open edit dialog with a double click, which sounds like is related to this issue.

Fix should be easy, so as always, community PRs are welcome.

@mlewand mlewand added this to the 4.7.1 milestone Jun 9, 2017
@msamsel msamsel self-assigned this Jun 9, 2017
@msamsel msamsel mentioned this issue Jun 9, 2017
2 tasks
@msamsel msamsel removed their assignment Jun 9, 2017
@Comandeer
Copy link
Member

The issue with double click is connected with fix for http://dev.ckeditor.com/ticket/11956 which also landed in 4.7.0, but it's completely unrelated to the one that cause this issue.

Comandeer added a commit that referenced this issue Jun 13, 2017
Fix edition of empty anchor

Fixes #476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

4 participants