Big document block typing

[dkrahn]

For performance issues, specially in big documents, I think the code below should be modified:

ckeditor5-angular/src/ckeditor/ckeditor.component.ts

Lines 258 to 268 in 63c0073

	modelDocument.on( 'change:data', ( evt: CKEditor5.EventInfo<'change:data'> ) => {
	const data = editor.getData();
	this.ngZone.run( () => {
	if ( this.cvaOnChange ) {
	this.cvaOnChange( data );
	}
	this.change.emit( { event: evt, editor } );
	} );
	} );

I would suggest the following:

modelDocument.on( 'change:data', ( evt: CKEditor5.EventInfo<'change:data'> ) => {
 	this.ngZone.run( () => {
 		if ( this.cvaOnChange ) {
 			const data = editor.getData(); 
 			this.cvaOnChange( data );
 		}
  
 		this.change.emit( { event: evt, editor } );
 	} );
 } );

Getting the data(getData()) only when it is necessary.

[dkrahn]

Hi @ma2ciek, I found this performance issue and did the PR #83 to fix it. Did I do it correctly?

[ma2ciek]

H1 @dkrahn

Thanks for the detailed issue and PR! This change makes sense indeed, it's a pity that I overlooked it. I'll add one test to your PR and will merge it.

[ma2ciek]

I'll try to release it soon.

[dkrahn]

Thanks for the great work you all are doing!!!