Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud integration #431

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Cloud integration #431

merged 2 commits into from
Sep 6, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Jul 26, 2024

Suggested merge commit message (convention)

Feature: Add cloud CDN support.

MAJOR BREAKING CHANGE: Changed minimum supported version of Angular to the oldest supported LTS: >= 16.x
MAJOR BREAKING CHANGE: Switched compiler from TS 4.x → 5.x to ensure compatibility with the newest CKEditor packages


Additional information

Related React integration: ckeditor/ckeditor5-react#510
Related Vue integration: ckeditor/ckeditor5-vue#301

Added demo: http://localhost:5000/simple-cdn-usage
Example usage:

import { Component, type OnInit } from '@angular/core';
import type { ClassicEditor } from 'https://cdn.ckeditor.com/typings/ckeditor5.d.ts';
import loadCKEditorCloud from 'src/ckeditor/cloud/load-ckeditor-cloud';

@Component( {
  selector: 'app-simple-cdn-usage',
  templateUrl: './simple-cdn-usage.component.html',
  styleUrls: [ './simple-cdn-usage.component.css' ]
} )
export class SimpleCdnUsageComponent implements OnInit {
  public Editor: typeof ClassicEditor | null = null;

  public ngOnInit(): void {
    loadCKEditorCloud( {
      version: '42.0.2'
    } )
      .then( cloud => {
        this.Editor = createCdnEditor( {
          cloud
        } );
      } );
  }
}

@coveralls
Copy link

coveralls commented Jul 26, 2024

Pull Request Test Coverage Report for Build eb32db8d-5b1c-432a-a592-71a85096bba9

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build e055574a-4028-4f2e-8b5f-4b9bf2017819: 0.0%
Covered Lines: 159
Relevant Lines: 159

💛 - Coveralls

package.json Outdated Show resolved Hide resolved
@Mati365 Mati365 merged commit 9c62280 into master Sep 6, 2024
5 checks passed
@Mati365 Mati365 deleted the ck/cloud-poc branch September 6, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants