Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp build --watch stopped watching changes. #181

Closed
oskarwrobel opened this issue May 24, 2016 · 6 comments
Closed

gulp build --watch stopped watching changes. #181

oskarwrobel opened this issue May 24, 2016 · 6 comments
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@oskarwrobel
Copy link
Contributor

Just after updating npm dependencies I've spotted that gulp doesn't refresh build after source file change. gulp-watch was updated yesterday https://github.com/floatdrop/gulp-watch/releases to 4.3.6. I've tried to downgrade to 4.3.5 and it helps.

Could someone confirm it?

@Reinmar
Copy link
Member

Reinmar commented May 24, 2016

Checking...

@Reinmar
Copy link
Member

Reinmar commented May 24, 2016

Unfortunately I can confirm this.

@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. module:builder labels May 24, 2016
@Reinmar
Copy link
Member

Reinmar commented May 24, 2016

I fixed the version temporarily: a38ce97.

@szymonkups
Copy link
Contributor

Ok, I've found the root of the issue and reported it here: floatdrop/gulp-watch#229

I found a way to make it work with current version of gulp-watch by creating globs with relative paths. We need to change this glob definition to this:

const glob = path.join( path.relative( config.ROOT_DIR, dirPath ), '@(src|tests)', '**', '*' );

But for now - let's wait for the gulp-watch maintainer to answer the issue.

@UltCombo
Copy link

Hey, gulp-watch maintainer here. We have just published [email protected] which fixes this issue. Please try it out and let us know if you experience any issues.

Special thanks to @szymonkups for helping us to identify the issue and test the patches.

@Reinmar
Copy link
Member

Reinmar commented Jun 20, 2016

Thanks for help, @UltCombo! :)

@Reinmar Reinmar added this to the 0.1.0 milestone Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants