Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve special character label styling #5817

Closed
mlewand opened this issue Nov 26, 2019 · 8 comments · Fixed by ckeditor/ckeditor5-special-characters#9
Closed

Improve special character label styling #5817

mlewand opened this issue Nov 26, 2019 · 8 comments · Fixed by ckeditor/ckeditor5-special-characters#9
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:special-characters type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@mlewand
Copy link
Contributor

mlewand commented Nov 26, 2019

📝 Provide a description of the new feature

In this release we decided to go with simplified labels (by using browser's title attribute) for special characters in the grid:

image

Reason we didn't use our good-looking tooltips is that grid has a hidden overflow in the CSS, this means that any labels shown at the edge would have the tooltips cropped.


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@mlewand mlewand added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). status:confirmed package:special-characters domain:ui/ux This issue reports a problem related to UI or UX. labels Nov 26, 2019
@mlewand mlewand added this to the nice-to-have milestone Nov 26, 2019
@oleq
Copy link
Member

oleq commented Nov 29, 2019

I propose the following compact solution since we cannot use the standard tooltips due to overflow issues:

Kapture 2019-11-29 at 11.40.29.gif

PoC is in two branches and only tests are missing:

cc @dkonopka

@mlewand
Copy link
Contributor Author

mlewand commented Dec 2, 2019

@oleq Looks fine. There's one detail though, is there any value in putting the character code? For most of mortal users this is unclear and confusing, while people who really, really need it will know how to check the character code.

@oleq
Copy link
Member

oleq commented Dec 2, 2019

is there any value in putting the character code?

I figured, if Google Docs offers it and there's unused space left in our "info bar", then why not.

@mlewand
Copy link
Contributor Author

mlewand commented Dec 2, 2019

TBH, IMO it still doesn't sound like it would be much of use for the end user.

@oleq
Copy link
Member

oleq commented Dec 2, 2019

I agree it's a gimmick. Do you have any other idea how to make use of this space?

@Reinmar
Copy link
Member

Reinmar commented Dec 17, 2019

@pomek, could you try to port @oleq's changes to current master? There are conflicts obviously due to the UI part being merged into the core part of the plugin. I think we liked the concept and if there's not much work to be done there, it'd be great to finish the effort. 

I'm reassigning the ticket to you.

@pomek
Copy link
Member

pomek commented Dec 17, 2019

What should I do with the "character code" section?

@Reinmar
Copy link
Member

Reinmar commented Dec 17, 2019

Since Olek proposed it, let's have it. I agree it doesn't bring much value but without it the layout will be weird. We can iterate on this to find the best solution, but for now let's have something.

@pomek pomek modified the milestones: nice-to-have, iteration 29 Dec 20, 2019
oleq added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Jan 2, 2020
Feature: Added the special character info view styles (see ckeditor/ckeditor5#5817).
oleq added a commit to ckeditor/ckeditor5-special-characters that referenced this issue Jan 2, 2020
Feature: Added the special character info bar that makes the feature more user–friendly. Closes ckeditor/ckeditor5#5817.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:special-characters type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants