Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TC] Cannot remove empty paragraph before a widget #7431

Closed
niegowski opened this issue Jun 15, 2020 · 0 comments · Fixed by #7435
Closed

[TC] Cannot remove empty paragraph before a widget #7431

niegowski opened this issue Jun 15, 2020 · 0 comments · Fixed by #7435
Assignees
@niegowski
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Milestone
iteration 33 (v20...

Comments

@niegowski
Copy link
Contributor

Steps to reproduce:

  1. Open track-changes manual test with latest master on ckeditor5
  2. Turn on TC
  3. Try to remove empty paragraph before a widget

Expected:

After accepting TC suggestion, the paragraph is removed

Actual:

After accepting TC suggestion, nothing happens

Notes:

  • bisection shows it was introduced in this commit in ckeditor5
  • I was not sure whether to report it here or in CKE5, but ended up here (sorry if not appropriate)

Screencast:

12_tc_widget
@niegowski niegowski added type:bug This issue reports a buggy (incorrect) behavior. package:engine type:regression This issue reports a bug that was not present in the previous releases. labels Jun 15, 2020
@niegowski niegowski added this to the iteration 33 milestone Jun 15, 2020
@niegowski niegowski self-assigned this Jun 15, 2020
@niegowski niegowski mentioned this issue Jun 15, 2020
Merged
oleq added a commit that referenced this issue Jun 16, 2020
@oleq
Merge pull request #7435 from ckeditor/i/7431
61a6110 
Internal (engine): Markers should not be considered a meaningful content in the  `Model#deleteContent()` context. Closes #7431.

Other (engine): Added the `ignoreMarkers` option to the `Model#hasContent()` method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Milestone
iteration 33 (v20.0.0)
1 participant
@niegowski