Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link ballon should re-position on window scroll (regression) #7705

Closed
oleq opened this issue Jul 24, 2020 · 3 comments · Fixed by #7842
Closed

Link ballon should re-position on window scroll (regression) #7705

oleq opened this issue Jul 24, 2020 · 3 comments · Fixed by #7842
Assignees
@mlewand
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Milestone
iteration 35 (v22...

Comments

@oleq
Copy link
Member

oleq commented Jul 24, 2020 •
edited by mlewand
Loading

📝 Provide detailed reproduction steps (if any)

  1. Select some text
  2. Open the link balloon
  3. Scroll the page

✔️ Expected result

The balloon sticks to the selection (like in v19.0.0).

❌ Actual result

The balloon position gets lost.

📃 Other details

  • Browser: cross-browser
  • CKEditor version: master

It's a regression introduced in v20.0.0.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:link domain:ui/ux This issue reports a problem related to UI or UX. type:regression This issue reports a bug that was not present in the previous releases. labels Jul 24, 2020
@oleq
Copy link
Member Author

oleq commented Jul 24, 2020

This looks nasty on mobile (check out the location of the balloon and the selection)

@oleq oleq mentioned this issue Jul 28, 2020
Closed
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:red labels Jul 28, 2020
@Reinmar
Copy link
Member

Reinmar commented Jul 28, 2020

We should start from bisecting this.

@Reinmar Reinmar added this to the iteration 35 milestone Jul 31, 2020
@oleq oleq assigned oleq and unassigned oleq Aug 12, 2020
@mlewand mlewand self-assigned this Aug 12, 2020
@mlewand
Copy link
Contributor

mlewand commented Aug 12, 2020

The regression has been introduced in v20.0.0. The first bad commit is 52e53e6 part of #7436 PR (#4721 issue).

This was referenced Aug 13, 2020
Closed
Merged
niegowski added a commit that referenced this issue Aug 17, 2020
@niegowski
Merge pull request #7842 from ckeditor/i/7705
5158209 
Fix (link): Fixed a case where the link balloon would point invalid place after browser scroll or resize. Closes #7705.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Milestone
iteration 35 (v22.0.0)
3 participants
@Reinmar @oleq @mlewand