-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use binary search in insertToPriorityArray
#17444
base: master
Are you sure you want to change the base?
Conversation
insertToPriorityArray
I think this change is safe enough to merge it into upcoming release @Witoso |
Good for me 👍 another good reason to bump the version! |
Does it affect the order of event listeners on the same priority? Until now, if there were multiple listeners on the same priority, then the order of registration was used. Does this PR change this? |
No. You can test the previous and current implementation on the following playground by running the |
Suggested merge commit message (convention)
Fix (utils): Use binary search in
insertToPriorityArray
for better performance when handling big tables.Reduces the time needed to render a table in the
tableHuge
test by ~67%.