1491 - Custom log levels can be silent unless level is also specified

.github/workflows/ci.yml

@@ -27,7 +27,7 @@ jobs:
           - 18
           - 20
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node }}

README.md

@@ -675,10 +675,21 @@ To colorize the standard logging level add
 ```js
 winston.format.combine(
   winston.format.colorize(),
-  winston.format.json()
+  winston.format.simple()
+);
+```
+where `winston.format.simple()` is whatever other formatter you want to use.  The `colorize` formatter must come before any formatters adding text you wish to color.
+
+### Colorizing full log line when json formatting logs
+
+To colorize the full log line with the json formatter you can apply the following
+
+```js
+winston.format.combine(
+  winston.format.json(),
+  winston.format.colorize({ all })
 );
 ```
-where `winston.format.json()` is whatever other formatter you want to use.  The `colorize` formatter must come before any formatters adding text you wish to color.
 
 ## Transports
 

index.d.ts

@@ -139,13 +139,6 @@ declare namespace winston {
     input: LeveledLogMethod;
     silly: LeveledLogMethod;
 
-    // for syslog levels only
-    emerg: LeveledLogMethod;
-    alert: LeveledLogMethod;
-    crit: LeveledLogMethod;
-    warning: LeveledLogMethod;
-    notice: LeveledLogMethod;
-
     query(
       options?: QueryOptions,
       callback?: (err: Error, results: any) => void

package.json

@@ -1,7 +1,7 @@
 {
   "name": "winston",
   "description": "A logger for just about everything.",
-  "version": "3.10.0",
+  "version": "3.11.0",
   "author": "Charlie Robbins <[email protected]>",
   "maintainers": [
     "David Hyde <[email protected]>"
@@ -25,7 +25,7 @@
   ],
   "dependencies": {
     "@dabh/diagnostics": "^2.0.2",
-    "@colors/colors": "1.5.0",
+    "@colors/colors": "^1.6.0",
     "async": "^3.2.3",
     "is-stream": "^2.0.0",
     "logform": "^2.4.0",
@@ -49,7 +49,7 @@
     "hock": "^1.4.1",
     "mocha": "8.1.3",
     "nyc": "^15.1.0",
-    "rimraf": "^3.0.2",
+    "rimraf": "^5.0.5",
     "split2": "^4.1.0",
     "std-mocks": "^1.0.1",
     "through2": "^4.0.2",

test/unit/winston/transports/01-file-maxsize.test.js

@@ -5,7 +5,7 @@
  * MIT LICENSE
  *
  */
-const rimraf = require('rimraf');
+const { rimraf } = require('rimraf');
 const fs = require('fs');
 const path = require('path');
 const assume = require('assume');
@@ -18,7 +18,7 @@ const MESSAGE = Symbol.for('message');
 // Remove all log fixtures
 //
 function removeFixtures(done) {
-  rimraf(path.join(testLogFixturesPath, 'testmaxsize*'), done);
+  rimraf(path.join(testLogFixturesPath, 'testmaxsize*')).then(() => done());
 }
 
 describe('File (maxsize)', function () {

test/unit/winston/transports/file-archive.test.js

@@ -8,7 +8,7 @@
 
 /* eslint-disable no-sync */
 const assert = require('assert');
-const rimraf = require('rimraf');
+const { rimraf } = require('rimraf');
 const fs = require('fs');
 const path = require('path');
 const winston = require('../../../../lib/winston');
@@ -20,7 +20,7 @@ const { MESSAGE } = require('triple-beam');
 // Remove all log fixtures
 //
 function removeFixtures(done) {
-  rimraf(path.join(testLogFixturesPath, 'testarchive*'), done);
+  rimraf(path.join(testLogFixturesPath, 'testarchive*')).then(() => done());
 }
 
 

test/unit/winston/transports/file-create-dir.test.js

@@ -4,15 +4,15 @@ const fs = require('fs');
 const assert = require('assert');
 const path = require('path');
 const winston = require('../../../../lib/winston');
-const rimraf = require("rimraf");
+const { rimraf } = require('rimraf');
 
 /* eslint-disable no-sync */
 
 describe('winston/transports/file/createLogDir', function () {
   const logDir = path.resolve(__dirname, '../../../fixtures/temp_logs');
 
   beforeEach(function () {
-    rimraf(logDir, (err) => {
+    return rimraf(logDir).catch(err => {
       if (err){
         console.log('Error encountered when removing `temp_logs` dir')
         console.log(err);

test/unit/winston/transports/file-rotationFormat.test.js

@@ -7,7 +7,7 @@ const fs = require('fs');
 const { MESSAGE } = require('triple-beam');
 const split = require('split2');
 const assume = require('assume');
-const rimraf = require('rimraf');
+const { rimraf } = require('rimraf');
 const testFileFixturesPath = path.join(
   __dirname,
   '..',
@@ -21,7 +21,7 @@ const testFileFixturesPath = path.join(
 // Remove all log fixtures
 //
 function removeFixtures(done) {
-  rimraf(path.join(testFileFixturesPath, 'rotation*'), done);
+  rimraf(path.join(testFileFixturesPath, 'rotation*')).then(() => done());
 }
 
 // Validate Filename according to rotation

test/unit/winston/transports/file-tailrolling.test.js

@@ -1,6 +1,6 @@
 /* eslint-disable no-sync */
 const assert = require('assert');
-const rimraf = require('rimraf');
+const { rimraf } = require('rimraf');
 const fs = require('fs');
 const path = require('path');
 const winston = require('../../../../lib/winston');
@@ -12,7 +12,7 @@ const { MESSAGE } = require('triple-beam');
 // Remove all log fixtures
 //
 function removeFixtures(done) {
-  rimraf(path.join(testLogFixturesPath, 'testtailrollingfiles*'), done);
+  rimraf(path.join(testLogFixturesPath, 'testtailrollingfiles*')).then(() => done());
 }