Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot override "clangd.path" per-workspace any more #64

Closed
HighCommander4 opened this issue Aug 31, 2020 · 2 comments · Fixed by #65
Closed

Cannot override "clangd.path" per-workspace any more #64

HighCommander4 opened this issue Aug 31, 2020 · 2 comments · Fixed by #65
Labels
bug Something isn't working

Comments

@HighCommander4
Copy link
Contributor

With vscode-clangd trunk, "clangd.path" cannot be overridden in Workspace settings any more, only User settings. This was regressed by #56, which made the pref scope=machine.

From the vscode docs, the description of scope=machine is:

machine - Machine specific settings that can be set in user or remote settings. For example, an installation path which shouldn't be shared across machines.

Note, it doesn't mention workspace settings.

I believe being able to override the clangd path per-workspace is useful. For example, I have two local clangd builds, a development build and a stable build, and it's useful to be able to run different ones in different workspaces.

There is a machine-overridable scope which does allow overriding in workspace settings perhaps we can use that instead:

machine-overridable - Machine specific settings that can be overridden by workspace or folder settings.

@HighCommander4 HighCommander4 added the bug Something isn't working label Aug 31, 2020
@hokein
Copy link
Collaborator

hokein commented Sep 1, 2020

Thanks for the report. I should have tested more about it locally (I test it with my personal workflow, which is fairly simple, just a single workspace with user setting).

Note, it doesn't mention workspace settings.

I believe being able to override the clangd path per-workspace is useful. For example, I have two local clangd builds, a development build and a stable build, and it's useful to be able to run different ones in different workspaces.

agree, that's unexpected.

There is a machine-overridable scope which does allow overriding in workspace settings perhaps we can use that instead:

this sounds reasonable to me, do you mind trying this and verifying it works on your case, and sending a PR to fix this? Thanks!

HighCommander4 added a commit to HighCommander4/vscode-clangd that referenced this issue Sep 2, 2020
This allows the setting to continue to be overridable per-workspace.

Fixes clangd#64
@HighCommander4
Copy link
Contributor Author

this sounds reasonable to me, do you mind trying this and verifying it works on your case, and sending a PR to fix this?

Yup, works for me. PR at #65.

sam-mccall pushed a commit that referenced this issue Sep 2, 2020
This allows the setting to continue to be overridable per-workspace.

Fixes #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants