Skip to content

Commit

Permalink
Update src/build/app/mod.rs
Browse files Browse the repository at this point in the history 
Co-Authored-By: Pavan Kumar Sunkara <[email protected]>
  • Loading branch information
@CreepySkeleton @pksunkara
CreepySkeleton and pksunkara authored Apr 11, 2020
1 parent 976ee7e commit fb159d4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/build/app/mod.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1748,7 +1748,7 @@ impl<'b> App<'b> {
}
if self.has_subcommands()
&& !self.is_set(AppSettings::DisableHelpSubcommand)
&& !self.get_subcommands().iter().any(|s| s.id == HELP_HASH)
&& !self.subcommands.iter().any(|s| s.id == HELP_HASH)
{
debugln!("App::_create_help_and_version: Building help");
self.subcommands.push(
Expand Down

2 comments on commit fb159d4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: fb159d4 Previous: 9060e3e Ratio
build_empty 99 ns/iter (± 1) 101 ns/iter (± 1) 0.98
parse_empty 970 ns/iter (± 18) 994 ns/iter (± 17) 0.98
parse_simple_with_complex 4032 ns/iter (± 97) 3764 ns/iter (± 84) 1.07
parse_simple_with_pos 3069 ns/iter (± 48) 2952 ns/iter (± 79) 1.04
parse_simple_with_opt 3247 ns/iter (± 50) 3260 ns/iter (± 62) 1.00
parse_simple_with_flag 2905 ns/iter (± 48) 2764 ns/iter (± 60) 1.05
build_with_pos_ref 234 ns/iter (± 6) 235 ns/iter (± 4) 1.00
build_with_pos 189 ns/iter (± 5) 198 ns/iter (± 3) 0.95
build_with_opt_ref 346 ns/iter (± 7) 347 ns/iter (± 6) 1.00
build_with_opt 270 ns/iter (± 4) 289 ns/iter (± 6) 0.93
build_with_flag_ref 299 ns/iter (± 6) 300 ns/iter (± 5) 1.00
build_with_flag 239 ns/iter (± 3) 259 ns/iter (± 6) 0.92
build_simple 728 ns/iter (± 11) 854 ns/iter (± 17) 0.85
build_from_usage 4822 ns/iter (± 69) 4496 ns/iter (± 92) 1.07
build_from_builder 2728 ns/iter (± 63) 2586 ns/iter (± 55) 1.05
build_from_macros 2697 ns/iter (± 43) 2436 ns/iter (± 56) 1.11
parse_complex 7381 ns/iter (± 109) 7515 ns/iter (± 130) 0.98
parse_complex_with_flag 8990 ns/iter (± 172) 8738 ns/iter (± 201) 1.03
parse_complex_with_opt 8869 ns/iter (± 204) 9258 ns/iter (± 205) 0.96
parse_complex_with_pos 9024 ns/iter (± 172) 8944 ns/iter (± 171) 1.01
parse_complex_with_sc 10644 ns/iter (± 221) 10542 ns/iter (± 227) 1.01
parse_complex_with_sc_flag 11813 ns/iter (± 213) 11619 ns/iter (± 245) 1.02
parse_complex_with_sc_opt 12222 ns/iter (± 304) 11919 ns/iter (± 311) 1.03
parse_complex_with_sc_pos 11708 ns/iter (± 207) 11419 ns/iter (± 210) 1.03
parse_complex1 14941 ns/iter (± 285) 14480 ns/iter (± 344) 1.03
parse_complex2 17607 ns/iter (± 392) 15865 ns/iter (± 302) 1.11
parse_args_negate_scs 16711 ns/iter (± 401) 15906 ns/iter (± 317) 1.05
parse_complex_with_sc_complex 13391 ns/iter (± 266) 12840 ns/iter (± 223) 1.04
example1 10476 ns/iter (± 153) 18573 ns/iter (± 397) 0.56
example2 373048 ns/iter (± 41449) 369658 ns/iter (± 38597) 1.01
example3 5685 ns/iter (± 150) 17682 ns/iter (± 289) 0.32
example4 5520 ns/iter (± 425) 12459 ns/iter (± 240) 0.44
example5 446506 ns/iter (± 39545) 469740 ns/iter (± 37419) 0.95
example6 5392 ns/iter (± 122) 10115 ns/iter (± 238) 0.53
example7 5332 ns/iter (± 111) 14317 ns/iter (± 360) 0.37
example8 5349 ns/iter (± 104) 13758 ns/iter (± 245) 0.39
example10 411663 ns/iter (± 38266) 423030 ns/iter (± 37512) 0.97
example4_template 4781 ns/iter (± 123) 11605 ns/iter (± 294) 0.41
build_rg_with_short_help 11863 ns/iter (± 239) 13142 ns/iter (± 289) 0.90
build_rg_with_long_help 13159 ns/iter (± 280) 13799 ns/iter (± 196) 0.95
write_rg_short_help 111837 ns/iter (± 2340) 107680 ns/iter (± 1860) 1.04
write_rg_long_help 255432 ns/iter (± 7094) 245441 ns/iter (± 5666) 1.04
parse_rg 25716 ns/iter (± 474) 27661 ns/iter (± 498) 0.93
parse_rg_with_complex 40186 ns/iter (± 936) 41401 ns/iter (± 1080) 0.97
parse_rg_with_lots 893182 ns/iter (± 17112) 870837 ns/iter (± 14574) 1.03
build_rustup 14249 ns/iter (± 408) 13932 ns/iter (± 288) 1.02
parse_rustup 19432 ns/iter (± 372) 17848 ns/iter (± 354) 1.09
parse_rustup_with_sc 19505 ns/iter (± 428) 18851 ns/iter (± 281) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: fb159d4 Previous: 9060e3e Ratio
build_empty 122 ns/iter (± 2) 111 ns/iter (± 1) 1.10
parse_empty 1128 ns/iter (± 58) 1117 ns/iter (± 24) 1.01
parse_simple_with_complex 4793 ns/iter (± 127) 4398 ns/iter (± 106) 1.09
parse_simple_with_pos 3393 ns/iter (± 59) 3652 ns/iter (± 93) 0.93
parse_simple_with_opt 3709 ns/iter (± 79) 3538 ns/iter (± 48) 1.05
parse_simple_with_flag 3391 ns/iter (± 87) 3104 ns/iter (± 28) 1.09
build_with_pos_ref 261 ns/iter (± 6) 270 ns/iter (± 7) 0.97
build_with_pos 208 ns/iter (± 2) 204 ns/iter (± 4) 1.02
build_with_opt_ref 407 ns/iter (± 12) 397 ns/iter (± 10) 1.03
build_with_opt 319 ns/iter (± 6) 309 ns/iter (± 3) 1.03
build_with_flag_ref 357 ns/iter (± 7) 341 ns/iter (± 3) 1.05
build_with_flag 271 ns/iter (± 4) 282 ns/iter (± 6) 0.96
build_simple 1105 ns/iter (± 18) 927 ns/iter (± 13) 1.19
build_from_usage 5596 ns/iter (± 133) 5604 ns/iter (± 128) 1.00
build_from_builder 3019 ns/iter (± 44) 2962 ns/iter (± 79) 1.02
build_from_macros 3038 ns/iter (± 39) 3194 ns/iter (± 73) 0.95
parse_complex 8889 ns/iter (± 168) 8941 ns/iter (± 173) 0.99
parse_complex_with_flag 11174 ns/iter (± 268) 9770 ns/iter (± 145) 1.14
parse_complex_with_opt 9930 ns/iter (± 97) 9816 ns/iter (± 124) 1.01
parse_complex_with_pos 10044 ns/iter (± 186) 10328 ns/iter (± 333) 0.97
parse_complex_with_sc 13300 ns/iter (± 416) 11839 ns/iter (± 246) 1.12
parse_complex_with_sc_flag 12832 ns/iter (± 153) 13159 ns/iter (± 183) 0.98
parse_complex_with_sc_opt 13001 ns/iter (± 236) 13888 ns/iter (± 326) 0.94
parse_complex_with_sc_pos 13015 ns/iter (± 147) 13388 ns/iter (± 371) 0.97
parse_complex1 16193 ns/iter (± 311) 17509 ns/iter (± 599) 0.92
parse_complex2 18593 ns/iter (± 286) 18351 ns/iter (± 445) 1.01
parse_args_negate_scs 18015 ns/iter (± 256) 17439 ns/iter (± 260) 1.03
parse_complex_with_sc_complex 14294 ns/iter (± 287) 14330 ns/iter (± 248) 1.00
example1 11690 ns/iter (± 354) 21866 ns/iter (± 553) 0.53
example2 381958 ns/iter (± 39871) 390168 ns/iter (± 40900) 0.98
example3 6462 ns/iter (± 123) 20279 ns/iter (± 702) 0.32
example4 6835 ns/iter (± 1250) 14124 ns/iter (± 373) 0.48
example5 481613 ns/iter (± 38182) 501492 ns/iter (± 41631) 0.96
example6 5979 ns/iter (± 144) 11101 ns/iter (± 282) 0.54
example7 5933 ns/iter (± 105) 15180 ns/iter (± 175) 0.39
example8 5931 ns/iter (± 112) 15186 ns/iter (± 229) 0.39
example10 442989 ns/iter (± 42378) 445710 ns/iter (± 39645) 0.99
example4_template 5640 ns/iter (± 111) 13167 ns/iter (± 252) 0.43
build_rg_with_short_help 13533 ns/iter (± 268) 13157 ns/iter (± 156) 1.03
build_rg_with_long_help 13560 ns/iter (± 191) 14674 ns/iter (± 193) 0.92
write_rg_short_help 122001 ns/iter (± 2128) 119039 ns/iter (± 1582) 1.02
write_rg_long_help 283740 ns/iter (± 9302) 277856 ns/iter (± 9262) 1.02
parse_rg 28803 ns/iter (± 576) 29962 ns/iter (± 535) 0.96
parse_rg_with_complex 45547 ns/iter (± 1426) 43559 ns/iter (± 883) 1.05
parse_rg_with_lots 1006211 ns/iter (± 23112) 952508 ns/iter (± 8124) 1.06
build_rustup 16671 ns/iter (± 326) 15292 ns/iter (± 167) 1.09
parse_rustup 19203 ns/iter (± 287) 20041 ns/iter (± 254) 0.96
parse_rustup_with_sc 19027 ns/iter (± 332) 20825 ns/iter (± 495) 0.91

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.