Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

help/version env parsing is different than other flags #3776

Closed
epage opened this issue Jun 1, 2022 · 0 comments · Fixed by #3973
Closed

help/version env parsing is different than other flags #3776

epage opened this issue Jun 1, 2022 · 0 comments · Fixed by #3973
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies E-easy Call for participation: Experience needed to fix: Easy / not much M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Milestone
4.0

Comments

@epage
Copy link
Member

epage commented Jun 1, 2022

help/version flags just care about presence while other bool flags parse the value. We should unifiy these so they all parse the value.
@epage epage added C-bug Category: Updating dependencies M-breaking-change Meta: Implementing or merging this will introduce a breaking change. A-parsing Area: Parser's logic and needs it changed somehow. E-easy Call for participation: Experience needed to fix: Easy / not much labels Jun 1, 2022
@epage epage added this to the 4.0 milestone Jun 1, 2022
epage added a commit to epage/clap that referenced this issue Jun 1, 2022
@epage
feat(builder): Set/Append Actions
95c812b 
This round out the new style actions and allow us to start deprecating
occurrences.

As part of an effort to unify code paths, this does change flag parsing
to do splits.  This will only be a problem if the user enables splits
but we'll at least not crash.  Once we also address clap-rs#3776, we'll be able
to have envs all work the same.
@epage epage mentioned this issue Jun 1, 2022
Merged
epage added a commit to epage/clap that referenced this issue Jul 22, 2022
@epage
fix(env)!: Parse help/version like normal
96cd86b 
Fixes clap-rs#3776
@epage epage mentioned this issue Jul 22, 2022
Merged
epage added a commit to epage/clap that referenced this issue Jul 22, 2022
@epage
fix(env)!: Parse help/version like normal
b77ed54 
Fixes clap-rs#3776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies E-easy Call for participation: Experience needed to fix: Easy / not much M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

fix(env)!: Parse help/version like normal epage/clap
1 participant
@epage