Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use &[&str] in "_all(Vec<&str>)" methods #53

Closed
kbknapp opened this issue Apr 2, 2015 · 1 comment
Closed

use &[&str] in "_all(Vec<&str>)" methods #53

kbknapp opened this issue Apr 2, 2015 · 1 comment
Assignees
@kbknapp
Labels
C-enhancement Category: Raise on the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change.

Comments

@kbknapp
Copy link
Member

kbknapp commented Apr 2, 2015

Allow slices in the _all(&[&str]) methods instead of a _all(Vec<&str>) to not require an extra allocation.
@kbknapp kbknapp added the C-enhancement Category: Raise on the bar on expectations label Apr 2, 2015
@kbknapp kbknapp self-assigned this Apr 2, 2015
@kbknapp kbknapp added the M-breaking-change Meta: Implementing or merging this will introduce a breaking change. label Apr 2, 2015
@kbknapp kbknapp changed the title use &[&str] in _all() methods use &[&str] in "_all(Vec<&str>)" methods Apr 2, 2015
@kbknapp
Copy link
Member Author

kbknapp commented Apr 2, 2015

This is going to be postponed, as I'm not sure the benefit is worth the break, or how much of a benefit there actually is...

Closing for now.

@kbknapp kbknapp closed this as completed Apr 2, 2015
@kbknapp kbknapp mentioned this issue Apr 29, 2015
Closed
epage added a commit that referenced this issue Dec 7, 2021
@epage
Merge pull request #53 from epage/migrate
aeb2958 
docs: Clean up 3.0 changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbknapp kbknapp

Labels
C-enhancement Category: Raise on the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kbknapp