Fix 978: global args' values available to all subcommands #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willmurphyscode, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer. |
Issue 978 mentions that subcommands cannot see the value of globals that get passed, even if ArgSettings::PropagateGlobalsDown is true. This change commits a failing test that reproduces this error.
This change lets us test multiple orderings of the global argument and subcommand issue with less duplicated code.
willmurphyscode
force-pushed
the
propagate-values-down
branch
from
e7743fd
to
ae060c3
Compare
This was referenced Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes and adds regression tests for #978.
Please let me know if there's any changes you'd like to make.
This change is