-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(OsValues): Add ExactSizeIterator
implementation
#1301
Conversation
It seems like an oversight that this was omitted.
Awesome, thanks! It looks like the Pinned nightly failed due to not being at least a 1.27 based nightly? Would you mind pinning a newer nightly in the Once the newer nightly is pinned, it should pass all lints from running |
The nightlies of 2018-06-22 don't work (rust-lang/rust#51699). |
OK, don't know how to find a working nightly. |
No worries! Usually it just involves fixing the things clippy is warning about. I can take a look and push some commits this weekend ;) |
Here is a relevant tweet that may be applicable here...looks like it wasn't just us https://twitter.com/RustStatus/status/1010240719527739392?s=19 |
The nightlies of 2018-06-22 don't work (rust-lang/rust#51699, https://twitter.com/RustStatus/status/1010240719527739392?s=19).
f679160
to
9f183d2
Compare
Build successful! \o/ |
Thanks for this! |
It seems like an oversight that this was omitted.
This change is