Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OsValues): Add ExactSizeIterator implementation #1301

Merged
merged 2 commits into from
Jun 23, 2018

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Jun 22, 2018

It seems like an oversight that this was omitted.


This change is Reviewable

It seems like an oversight that this was omitted.
@mention-bot
Copy link

@tbu-, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer.

@kbknapp
Copy link
Member

kbknapp commented Jun 22, 2018

Awesome, thanks!

It looks like the Pinned nightly failed due to not being at least a 1.27 based nightly? Would you mind pinning a newer nightly in the .travis.yml?

Once the newer nightly is pinned, it should pass all lints from running cargo build --features lints (which just runs Clippy) to ensure there aren't new clippy lints which fail on that nightly (hence the reason for pinning a specific Nightly compiler version).

@tbu-
Copy link
Contributor Author

tbu- commented Jun 22, 2018

The nightlies of 2018-06-22 don't work (rust-lang/rust#51699).

@tbu-
Copy link
Contributor Author

tbu- commented Jun 22, 2018

OK, don't know how to find a working nightly.

@kbknapp
Copy link
Member

kbknapp commented Jun 22, 2018

No worries! Usually it just involves fixing the things clippy is warning about. I can take a look and push some commits this weekend ;)

@kbknapp
Copy link
Member

kbknapp commented Jun 23, 2018

Here is a relevant tweet that may be applicable here...looks like it wasn't just us

https://twitter.com/RustStatus/status/1010240719527739392?s=19

@tbu- tbu- force-pushed the pr_osvalues_exactsizeiterator branch from f679160 to 9f183d2 Compare June 23, 2018 13:17
@tbu-
Copy link
Contributor Author

tbu- commented Jun 23, 2018

Build successful! \o/

@kbknapp
Copy link
Member

kbknapp commented Jun 23, 2018

Thanks for this!

@kbknapp kbknapp merged commit 1a654a9 into clap-rs:master Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants