fix: Don't print 'OPTIONS' when all options are hidden for short help #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We recently refactored this part of the code. You will have to wait for #1824 to be merged into master (should be soon) and then rebase on top of master. Really appreciate the contribution though. |
|
No issues with the code. I should be able to merge it once you rebase. 😄 |
|
Awesome! I've subscribed to the other PR so I am alerted when it is merged. I am also happy to fix the linting issues related to my code: EDIT: Oops, I just saw that the other PR was already merged. |
|
Yes please fix the lint, otherwise the CI will fail. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't print the 'OPTIONS' section of the short help message when all option-taking arguments are set with
.hidden_short_help(true).Closes #1364