Fix positional args in groups (#1794) #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreepySkeleton
force-pushed
the
groups_bugfix
branch
from
fb88932
to
e1367ca
Compare
pksunkara
reviewed
Apr 23, 2020
pksunkara
reviewed
Apr 23, 2020
pksunkara
approved these changes
Apr 23, 2020
|
@pksunkara can we have something like "re-run all CI checks" button? |
CreepySkeleton
force-pushed
the
groups_bugfix
branch
from
b118992
to
7a09195
Compare
|
I don't know anyway to implement it |
|
Nah, never mind |
|
bors r+ |
|
Build succeeded:
|
ldm0
added a commit
to ldm0/clap
that referenced
this pull request
Dec 26, 2020
ldm0
added a commit
to ldm0/clap
that referenced
this pull request
Dec 29, 2020
ldm0
added a commit
to ldm0/clap
that referenced
this pull request
Jan 17, 2021
Merged
ldm0
added a commit
to ldm0/clap
that referenced
this pull request
Jan 19, 2021
ldm0
added a commit
to ldm0/clap
that referenced
this pull request
Jan 23, 2021
Merged
ldm0
added a commit
to ldm0/clap
that referenced
this pull request
Jan 23, 2021
ldm0
added a commit
to ldm0/clap
that referenced
this pull request
Jan 27, 2021
ldm0
added a commit
to ldm0/clap
that referenced
this pull request
Feb 5, 2021
Dehack, revert clap-rs#1856 Fix incorrect error message. Comment out regressed logic Fix clippy Minor redundant logic cleanup Fix clippy dot fix Clearer error processing Acc a request Flow reordering Remove redundant ClapResult in some functions Flow optimize Integrate workflow Branch simpification Simplify possible subcommand Optimize branch, more comments Eliminate unreachable branch comment fix Add comments for some internal app settings Resolve a TODO Unused clippy allow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1794
The bug was fairly easy to diagnose but extremely hard to fix. I managed a small not-too-hacky hack, but it comes at cost. I believe we can pay it. See the comment in the diff for the explanation.