Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changes doc comments to rustdoc comments #302

Closed
wants to merge 4 commits into from
Closed

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Oct 1, 2015

This changes the doc comments to real rustdoc comments....mistake of mine earlier 😜

@yo-bot
Copy link

yo-bot commented Oct 1, 2015

r? @Vinatorul

(yo-bot has picked a reviewer for you, use r? to override)

@sru
Copy link
Contributor

sru commented Oct 1, 2015

Why not put them on the top of the file to be safe?

@kbknapp
Copy link
Member Author

kbknapp commented Oct 1, 2015

Will do once I get home ;)

@kbknapp
Copy link
Member Author

kbknapp commented Oct 1, 2015

Actually, @sru can you make that commit to this branch and merge? It might be some time before I get to a computer

@sru
Copy link
Contributor

sru commented Oct 2, 2015

Done, but I am not sure about those "see documentation" and referencing to itself. I'd assume that if a person sees the top level documentation, they are currently in the documentation.

@kbknapp
Copy link
Member Author

kbknapp commented Oct 2, 2015

The ignore and full URL links have to go in the crate docs because rustdoc doesn't handle them too well (and the direct file links don't exist in the docs branch).

@kbknapp
Copy link
Member Author

kbknapp commented Oct 2, 2015

Closing this in favor of #304

I'm not sure how to revert a commit that's been pushed, I've only done it locally 😜

@kbknapp kbknapp closed this Oct 2, 2015
@sru
Copy link
Contributor

sru commented Oct 2, 2015

@kbknapp I am not sure what you mean. I just made the link reference at the bottom (not file links), so that the text doesn't get cluttered much. And I don't know what ignore does to the code snippet.

@kbknapp
Copy link
Member Author

kbknapp commented Oct 2, 2015

Aaah, my mistake! I thought you changed it back to file links like in the original readme. Moving them to the bottom is a good idea 👍

The ignore tells rustdoc not to try and compile or run the snippets. Rust snippets can be marked as no_run which tells rustdoc to compile (and ensure the syntax is correct), but not run attempt to run them.

@kbknapp kbknapp mentioned this pull request Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants