Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clarify explicit display order wins #3138

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Conversation

epage
Copy link
Member

@epage epage commented Dec 9, 2021

Now that we use options, we can rely on that, instead of sentinels, for
detecting a default and overriding only a default.

Noticed this as part of looking at #1807.

Now that we use options, we can rely on that, instead of sentinels, for
detecting a default and overriding only a default.

Noticed this as part of looking at clap-rs#1807.
@epage epage added the M-unreviewed Meta: Request for post-merge review. label Dec 10, 2021
@epage epage merged commit 313b5e3 into clap-rs:master Dec 10, 2021
@epage epage deleted the disp branch December 10, 2021 00:30
@pksunkara pksunkara removed the M-unreviewed Meta: Request for post-merge review. label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants