Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(derive): Merge handling of bool/from_flag #3782

Merged
merged 5 commits into from
Jun 2, 2022
Merged

refactor(derive): Merge handling of bool/from_flag #3782

merged 5 commits into from
Jun 2, 2022

Commits on Jun 2, 2022

  1. refactor(derive): Simplify needs for finding the inner type

    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    96ac83e View commit details
    Browse the repository at this point in the history

  2. refactor(derive): Resolve value parsers earlier

    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    f61aad4 View commit details
    Browse the repository at this point in the history

  3. refactor(derive): Default parser based on type

    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    e5ead4c View commit details
    Browse the repository at this point in the history

  4. test(derive): Update ui test to be correct otherwise

    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    dfc55cd View commit details
    Browse the repository at this point in the history

  5. refactor(derive): Merge handling of bool/from_flag 

    This will make it easier to divide off parser logic for adding in
actions.

This does mean we can't provide error reporting on bad values with
`bool` but
- We should have also been doing that for `from_flag`
- We'll be dropping this soon in clap4 anyways
    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    773ba94 View commit details
    Browse the repository at this point in the history