Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(derive): Prepare for action support #3783

Merged
merged 7 commits into from
Jun 3, 2022
Merged

refactor(derive): Prepare for action support #3783

merged 7 commits into from
Jun 3, 2022

Commits on Jun 2, 2022

  1. fix(derive): Reference correct path

    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    e5f2911 View commit details
    Browse the repository at this point in the history

  2. fix(derive): Fix typo in error messages

    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    cccc88b View commit details
    Browse the repository at this point in the history

  3. refactor(derive): Clarify functions role

    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    ebf9c16 View commit details
    Browse the repository at this point in the history

  4. refactor(derive): Give new-style highest precedence 

    This exposed a potential bug but I figure it isn't worth fixing without
actions.
    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    f4004b6 View commit details
    Browse the repository at this point in the history

  5. fix(derive): Adjust precedence for flag/occurrence logic

    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    552e6fe View commit details
    Browse the repository at this point in the history

  6. Revert "fix(parser): Don't treat missing values as missing args" 

    This reverts commit 50f4018.

This broke compatibility with the derive when dealing with
`Option<Option<T>>` and related cases.
    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    002d442 View commit details
    Browse the repository at this point in the history

  7. test(derive): Ensure we don't break compatibility

    @epage
    epage committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    5db6113 View commit details
    Browse the repository at this point in the history