Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 367 #386

Merged
merged 7 commits into from
Jan 26, 2016
Merged

Issue 367 #386

merged 7 commits into from
Jan 26, 2016

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Jan 25, 2016

No description provided.

@yo-bot
Copy link

yo-bot commented Jan 25, 2016

r? @sru

(yo-bot has picked a reviewer for you, use r? to override)

@yo-bot
Copy link

yo-bot commented Jan 25, 2016

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against v2-master. Please double check that you specified the right target!

@@ -596,7 +596,7 @@ impl Error {
{
let a = arg.into();
Error {
message: format!("{} The argument '{}' wasn't recognized, or isn't valid{}\n\
message: format!("{} The argument '{}' wasn't recognized, or isn't valid in this context{}\n\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke the Python tests.

@kbknapp
Copy link
Member Author

kbknapp commented Jan 25, 2016

I'm OK with AppVeyor failing for now, as once I have these features/issues knocked out I'll get it passing again.

kbknapp added a commit that referenced this pull request Jan 26, 2016
@kbknapp kbknapp merged commit 3b9aada into v2-master Jan 26, 2016
@kbknapp kbknapp deleted the issue-367 branch January 26, 2016 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants