Bug fixes, new setting, code clean up, and added support u64::max values per arg #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sru (yo-bot has picked a reviewer for you, use r? to override) |
kbknapp
changed the title
|
88% coverage! Almost to 90! |
|
@homu r+ |
|
📌 Commit c31c2fb has been approved by |
homu
added a commit
that referenced
this pull request
Feb 3, 2016
Bug fixes, new setting, code clean up, and added support u64::max values per arg This turned into a little more than just a quick bug fix 😜 Thanks to #409 I've piggy backed on that and added support for > 256 values as well. There's also just a bunch of code deduping and super small macro cleanups. After this merges I'll put out 2.0.3
homu
added a commit
that referenced
this pull request
Feb 3, 2016
Bug fixes, new setting, code clean up, and added support u64::max values per arg This turned into a little more than just a quick bug fix 😜 Thanks to #409 I've piggy backed on that and added support for > 256 values as well. There's also just a bunch of code deduping and super small macro cleanups. After this merges I'll put out 2.0.3
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned into a little more than just a quick bug fix 😜
Thanks to #409 I've piggy backed on that and added support for > 256 values as well.
There's also just a bunch of code deduping and super small macro cleanups.
After this merges I'll put out 2.0.3