Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.0.4 #413

Merged
merged 6 commits into from
Feb 4, 2016
Merged

V2.0.4 #413

merged 6 commits into from
Feb 4, 2016

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Feb 4, 2016

Common 90% coverage! 🙏

@kbknapp
fix: adds support for building ArgGroups from standalone YAML
fcbc7e1 
ArgGroups can now be built from standalone YAML documents. This is
labeled as a fix because it should have been the case prior. A
standalone YAML document for a group would look something like

```
name: test
args:
    - arg1
    - arg2
required: true
conflicts:
    - arg3
requires:
    - arg4
```

This commit also keeps support building groups as part of a larger
entire App YAML document where the name is specified as a key to the
yaml tree
@kbknapp
tests(ArgGroup): adds additional tests including YAML
2bc1908
@kbknapp
refactor(macros): removes ok() from Result.ok().expect()
7166f4f
@kbknapp
tests(Suggestions): adds additional tests
8bcbce2
@kbknapp
tests: adds tests for stdin char and only positional vals follow
a33e3df
@kbknapp
chore: increase version
9f7a4af
@yo-bot
Copy link

yo-bot commented Feb 4, 2016

r? @Vinatorul

(yo-bot has picked a reviewer for you, use r? to override)

@kbknapp kbknapp mentioned this pull request Feb 4, 2016
Closed
@kbknapp
Copy link
Member Author

kbknapp commented Feb 4, 2016

@Vinatorul looks like that coveralls bug again...how did you fix it last time?

@Vinatorul
Copy link
Contributor

@kbknapp I have restarted travis build for stable branch. But I think the problem is not in coveralls now.

Uploading coverage
kcov: warning: coveralls write failed: {"message":"Couldn't find a repository matching this job.","error":true}
kcov: warning: coveralls write failed: {"message":"Couldn't find a repository matching this job.","error":true}

@Vinatorul
Copy link
Contributor

As I can see on their status page - they have some problems now

@kbknapp
Copy link
Member Author

kbknapp commented Feb 4, 2016

Yep, a bunch of people are starting to post on their issues page:

lemurheavy/coveralls-public#487

We'll merge this for now, because I know the coverage didn't decrease 😉

@homu r+

@homu
Copy link
Contributor

homu commented Feb 4, 2016

📌 Commit 9f7a4af has been approved by kbknapp

homu added a commit that referenced this pull request Feb 4, 2016
@homu
Auto merge of #413 - kbknapp:v2.0.4, r=kbknapp
6378fc1 
V2.0.4

Common 90% coverage! 🙏
homu added a commit that referenced this pull request Feb 4, 2016
@homu
Auto merge of #413 - kbknapp:v2.0.4, r=kbknapp
990ddfb 
V2.0.4

Common 90% coverage! 🙏
@homu
Copy link
Contributor

homu commented Feb 4, 2016

⌛ Testing commit 9f7a4af with merge 990ddfb...

@Vinatorul
Copy link
Contributor

@kbknapp have you noticed that homu had created two branches auto and homu-tmp?

@homu
Copy link
Contributor

homu commented Feb 4, 2016

☀️ Test successful - status

@homu homu merged commit 9f7a4af into master Feb 4, 2016
@kbknapp kbknapp deleted the v2.0.4 branch February 4, 2016 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vinatorul Vinatorul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbknapp @yo-bot @Vinatorul @homu