Backport Bugfix/3861 to V3: Mangen not showing possible values #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds feature parity for mangen with the standard help output. Users will now see the list of possible values for value arguments. One change that was made to make this possible was adding the method `get_possible_values` to the public API for an arg. I tried to think of a way to get around this, but because this is the interface that the help generation uses, and it is part of the crate public interface I thing adding it as a part of the public API might be for the best. cherry-pick to backport this fix to v3 fixes: clap-rs#3861
This makes sure we take into account the setting that possible args is hidden backporting to v3-master
Calder-Ty
force-pushed
the
bugfix/3861_backport
branch
from
64cc295
to
636b91c
Compare
Calder-Ty
changed the title
Calder-Ty
force-pushed
the
bugfix/3861_backport
branch
2 times, most recently
from
bdaf096
to
9bf3cf2
Compare
epage
reviewed
Aug 30, 2022
Noticed that possible values would not show up for Positional arguments as well. Decided to add the changes for those as well.
Calder-Ty
force-pushed
the
bugfix/3861_backport
branch
from
9bf3cf2
to
f7af765
Compare
|
Good catch. Dropped the interloping line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request cherry picks the commits from #4082 to fix #3861 for v3.