Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(derive): Clean up in prep for parent attributes #4184

Merged
merged 17 commits into from
Sep 6, 2022
Merged

refactor(derive): Clean up in prep for parent attributes #4184

merged 17 commits into from
Sep 6, 2022

Commits on Sep 4, 2022

  1. refactor(derive): Separate parsing from pushing of attrs

    @epage
    epage committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    9abcae2 View commit details
    Browse the repository at this point in the history

  2. refactor(derive): Decouple attr and kind processing

    @epage
    epage committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    f571821 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. refactor(derive): Remove unused Type for values 

    They have no type
    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    6648cf6 View commit details
    Browse the repository at this point in the history

  2. fix(derive): Improve the default span

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    f9e1ba2 View commit details
    Browse the repository at this point in the history

  3. refactor(derive): Delay error handling

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    b29f3ff View commit details
    Browse the repository at this point in the history

  4. fix(derive): Be less prescriptive 

    With how flexible clap's API is, it can be hard to determine what is
reasonable to use with its API, so let's just stop.
    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    ade931b View commit details
    Browse the repository at this point in the history

  5. refactor(derive): Simplify Kind initialization

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    71b9209 View commit details
    Browse the repository at this point in the history

  6. refactor(derive): Give more control to the derive

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    eece51f View commit details
    Browse the repository at this point in the history

  7. perf(derive): Don't parse ValueEnum's doc comment to ignore it

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    1d973bd View commit details
    Browse the repository at this point in the history

  8. fix(derive): Disallow attributes on top-level ValuEnum

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    9eb72ea View commit details
    Browse the repository at this point in the history

  9. perf(derive): Only parse doc comments when needed for field/variant

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    8a5a9ba View commit details
    Browse the repository at this point in the history

  10. fix(derive): Improve skip method error 

    Really this is about consolidating the skip checks but it also provideda
chance to improve the error.
    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    abcee38 View commit details
    Browse the repository at this point in the history

  11. refactor(derive): Shift responsibility for long help

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    a71b2eb View commit details
    Browse the repository at this point in the history

  12. fix(derive): Disallow general attributes with from_global

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    222003a View commit details
    Browse the repository at this point in the history

  13. refactor(derive): Treat subcommands like other Kinds

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    51dc3c6 View commit details
    Browse the repository at this point in the history

  14. refactor(derive): Simplify processing of Subcommand

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    9c85839 View commit details
    Browse the repository at this point in the history

  15. style(derive): Clean up to make explicit methods easier

    @epage
    epage committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    ede8fd6 View commit details
    Browse the repository at this point in the history