New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grouped_values_of to use typed API and add support in derive #4544

Merged

epage merged 1 commit into clap-rs:master from tmccombs:group-action

Dec 21, 2022

Contributor

tmccombs commented Dec 9, 2022 •

edited by epage

Loading

A step towards #2924

tmccombs commented

View reviewed changes

clap_derive/src/utils/ty.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

src/parser/matches/arg_matches.rs Show resolved Hide resolved

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

src/parser/matches/arg_matches.rs Show resolved Hide resolved

tmccombs mentioned this pull request

Stablize ArgMatches::grouped_value_of Tracking Issue #2924

Closed

4 tasks

tmccombs force-pushed the group-action branch 3 times, most recently from 006e9aa to 2a420ac Compare

December 12, 2022 08:36

epage reviewed

View reviewed changes

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

tmccombs force-pushed the group-action branch 2 times, most recently from bd4d79f to 3b2feb0 Compare

December 16, 2022 08:19

tmccombs marked this pull request as ready for review

December 16, 2022 08:30

Contributor Author

tmccombs commented Dec 16, 2022

hmm, it looks like rust 1.66 changed the Debug format for PhantomData, which is causing the test for value_parser::value_parser to fail. I'm not sure what to do about that, since updating the test would cause it to fail on older versions of rust.

Member

epage commented Dec 19, 2022

Rebase and tests should get past that problem

epage reviewed

View reviewed changes

src/parser/matches/arg_matches.rs Outdated Show resolved Hide resolved

tmccombs force-pushed the group-action branch 2 times, most recently from 6e660dc to 1f44263 Compare

December 20, 2022 07:08

Contributor Author

tmccombs commented Dec 20, 2022

Rebase and tests should get past that problem

It looks like master is currently failing in the same way.

Member

epage commented Dec 20, 2022

Oops, forgot to push


          feat: Add get/remove API for getting grouped values

6abc2cf

Change it to be more consistent with get_one and get_many and related
functions.

Relates-To: clap-rs#2924

tmccombs force-pushed the group-action branch from 1f44263 to 6abc2cf Compare

December 21, 2022 05:50

Member

epage commented Dec 21, 2022

Thanks!

epage merged commit 957288c into clap-rs:master

tmccombs deleted the group-action branch

December 21, 2022 16:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet