Implement helper methods for PathBufValueParser
#4686
Conversation
Resolves a few of the use cases outlined in clap-rs#4074.
There was a problem hiding this comment.
Sorry for the delay in getting to you on this.
As I mentioned in the Issue, I was thinking this would likely be best to start off as a clap_fs crate, rather than directly supporting this in clap.
If you go this route, it would help if you split the commits to make this easy to review
- One commit just adding an empty
clap_fscrate, following the pattern of other crates - One commit adding the desired functionality with tests and examples
If you would like to further discuss design ideas (as compared to the implementation), let's do that over on the issue.
| option_set_func!(String, (starts_with, ends_with)); | ||
| option_set_func!( |
There was a problem hiding this comment.
I'd prefer we not use macros for all of the functions as it obscures what is happening
| starts_with: Option<String>, | ||
| ends_with: Option<String>, |
There was a problem hiding this comment.
I'm not seeing these defined in click. Let's hold off on these in this PR and instead discuss their use case in the issue
|
Sounds good @epage! I'll take a look into that 😄 |
|
Thanks for the heads up! I was in the process of trying to create a creat to do this as you'd suggested, but it looks like this will work well. |
Resolves a few of the use cases outlined in #4074, albeit with different function names. The function names match the function names of
PathBuf.