Push indices for arguments taking optional values #4909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
When an argument takes an optional value (e.g. `.num_args(0..=1)`), make sure an index is pushed: * when a value is specified, for each value * when no value is specified, for the option, similar to a flag. Note: this means that a MatchedArg's `num_vals` no longer necessarily matches the number of indices. Fixes clap-rs#2419
fabianfreyer
force-pushed
the
fix/issue-2419
branch
from
260fe0e
to
db8995d
Compare
|
Let's agree on requirements and solution before moving to a PR |
|
Sure! This was really just meant to be a prototype / basis for discussion in #2419, since that seemed to have ground to a halt -- happy to continue the discussion over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an argument takes an optional value (e.g.
.num_args(0..=1)), make sure an index is pushed:Note: this means that a MatchedArg's
num_valsno longer necessarily matches the number of indices.Fixes #2419