Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues 512,518,519 #520

Merged
merged 17 commits into from
Jun 8, 2016
Merged

Issues 512,518,519 #520

merged 17 commits into from
Jun 8, 2016

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Jun 4, 2016

No description provided.

kbknapp added 15 commits June 4, 2016 11:28
Color are now only used when outputting to a termainal/TTY. There are three new settings as well
which can be used to control color output, they are:

 * `AppSettings::ColorAuto`: The default, and will only output color when outputting to a terminal or TTY
 * `AppSettings::ColorAlways`: Outputs color no matter where the output is going
 * `AppSettings::ColorNever`: Never colors output

This now allows one to use things like command line options, or environmental variables to turn
colored output on/off.

Closes #512
…gle positional arg is present

Instead of blindly printing `[ARGS]` when only a single positional arg is present, it will now
print `[NAME]` (or `[NAME]...` for multiple values allowed)

Closes #518
@yo-bot
Copy link

yo-bot commented Jun 4, 2016

r? @Vinatorul

(yo-bot has picked a reviewer for you, use r? to override)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.612% when pulling 0d541a2 on issues-512,518,519 into 34e608c on master.

@kbknapp kbknapp force-pushed the issues-512,518,519 branch 3 times, most recently from f4000bf to 536eb6d Compare June 7, 2016 01:11
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.612% when pulling 536eb6d on issues-512,518,519 into 34e608c on master.

@coveralls
Copy link

coveralls commented Jun 7, 2016

Coverage Status

Coverage increased (+0.1%) to 85.612% when pulling 0a05bb9 on issues-512,518,519 into 34e608c on master.

@kbknapp kbknapp force-pushed the issues-512,518,519 branch 2 times, most recently from 8782a30 to 01e7dfd Compare June 8, 2016 00:49
@kbknapp
Copy link
Member Author

kbknapp commented Jun 8, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Jun 8, 2016

📌 Commit 01e7dfd has been approved by kbknapp

homu added a commit that referenced this pull request Jun 8, 2016
homu added a commit that referenced this pull request Jun 8, 2016
@homu
Copy link
Contributor

homu commented Jun 8, 2016

⌛ Testing commit 01e7dfd with merge a77c800...

@homu
Copy link
Contributor

homu commented Jun 8, 2016

☀️ Test successful - status

@homu homu merged commit 01e7dfd into master Jun 8, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.612% when pulling 01e7dfd on issues-512,518,519 into 34e608c on master.

@kbknapp kbknapp deleted the issues-512,518,519 branch June 8, 2016 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants