New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support delimited values in native completions #5602

Merged

epage merged 2 commits into clap-rs:master from shannmu:delimiter_values

Aug 16, 2024

Contributor

shannmu commented Jul 26, 2024 •

edited

Loading

Related issue #3922

Support --flag bar1,bar1,[TAB]
Support --flag=bar1,bar2,[TAB]
Support -F bar1,bar2,[TAB]
Support -F=bar1,bar2,[TAB]
Support delimited values for positional argument in native completions. -- a_pos,[TAB]

Member

epage commented Jul 26, 2024

Should we support delimited values for positional argument in native completions.

Yes, a value is a value

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

shannmu force-pushed the delimiter_values branch from 12104ef to 6c57658 Compare

August 5, 2024 16:47

shannmu marked this pull request as ready for review

August 5, 2024 16:55

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

shannmu mentioned this pull request

Support allow_hyphen_values in native completions #5594

Closed

2 tasks

shannmu force-pushed the delimiter_values branch from 6c57658 to e1d7a31 Compare

August 6, 2024 10:20

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

shannmu force-pushed the delimiter_values branch from e1d7a31 to 359832d Compare

August 7, 2024 10:37

Member

epage commented Aug 15, 2024

Things should be calmer now for updating for merge conflicts

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

shannmu force-pushed the delimiter_values branch 2 times, most recently from 593553a to 2858219 Compare

August 16, 2024 04:24

shannmu added 2 commits

August 16, 2024 15:54


          test(clap_complete): Add test cases for delimiter_values support

ccecab3


          feat(clap_complete): Support delimiter values in native completions

59bf26d

epage force-pushed the delimiter_values branch 2 times, most recently from bb80638 to 59bf26d Compare

August 16, 2024 21:07

epage merged commit 82e599e into clap-rs:master

22 of 23 checks passed

epage mentioned this pull request

Support delimited values for native completions #3922

Open

epage mentioned this pull request

Support allow_hyphen_values in native completions #5628

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet