Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): split paragraphs on lines ending with double space or backslash #5803

Closed

Conversation

JohanVonElectrum
Copy link

closes #5802

@epage
Copy link
Member

epage commented Nov 4, 2024

In our contributor documentation, we ask for Issues before PRs, see https://github.com/clap-rs/clap/blob/master/CONTRIBUTING.md#where-to-start

This isn't just a prefunctory task but to make sure we are aligned on the problem and the solution before putting in effort into a PR and to make sure there is capacity for reviewing your PR. In fact, This PR does little to explain what it is doing. We also have had solution discussions in #2389. I'd recommend proposing your idea in #2389 before we move forward with a solution and as such I'm closing this for now to keep the focus on #2389.

@epage epage closed this Nov 4, 2024
@JohanVonElectrum
Copy link
Author

Thank you for the clarification and feedback. I initially created this fix for personal use and shared it as a potential solution. Before submitting, I searched for issues related to newlines but didn’t come across #2389, as it focuses on general markdown parsing. I’ll follow the discussions there and contribute under that umbrella moving forward. I’ll continue using my fork in the meantime. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paragraphs for long help derived from doc comments may be splitted on more cases
2 participants