Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrapping bugs #832

Merged
merged 4 commits into from
Jan 31, 2017
Merged

Fix wrapping bugs #832

merged 4 commits into from
Jan 31, 2017

Commits on Jan 30, 2017

  1. fix: include final character in line lenght 

    Before, wrapping the help text at, say, 80 characters really meant
that every line could be at most 79 characters wide.

Lines can now be up to and including avail_chars columns wide.

If needed, a desired margin or padding can be subtracted from the
avail_chars argument at a later point.
    @mgeisler
    mgeisler committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    aff4ba1 View commit details
    Browse the repository at this point in the history

  2. fix: actually show character in debug output 

    The &help[j..j] string slice was empty so nothing was shown.
    @mgeisler
    mgeisler committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    84d8c54 View commit details
    Browse the repository at this point in the history

  3. tests: show how final word is not always wrapped 

    This is clap-rs#828.
    @mgeisler
    mgeisler committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    563a539 View commit details
    Browse the repository at this point in the history

  4. fix: allow final word to be wrapped in wrap_help 

    Before, inserting a newline did not move the prev_space index forward.
This meant that the next word was measured incorrectly since the
length was measured back to the word before the newly inserted
linebreak.

Fixes clap-rs#828.
    @mgeisler
    mgeisler committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    564c5f0 View commit details
    Browse the repository at this point in the history