Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call this PR "Raid" cause it's squashin bugs! #843

Merged
merged 13 commits into from
Feb 3, 2017
Merged

Call this PR "Raid" cause it's squashin bugs! #843

merged 13 commits into from
Feb 3, 2017

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Feb 3, 2017

No description provided.

@kbknapp kbknapp changed the title Bugs rollup Call this PR "Raid" cause it's squashin bugs! Feb 3, 2017
@kbknapp kbknapp mentioned this pull request Feb 3, 2017
Closed
@kbknapp kbknapp force-pushed the bugs-rollup branch 2 times, most recently from 55cb97b to 8c0984a Compare February 3, 2017 19:24
@coveralls
Copy link

coveralls commented Feb 3, 2017 •
edited
Loading

Coverage Status

Coverage increased (+2.7%) to 91.783% when pulling 55cb97b on bugs-rollup into 75e815a on master.

@nabijaczleweli
Copy link
Contributor

Sponsored much?

@kbknapp
Copy link
Member Author

kbknapp commented Feb 3, 2017

Coveralls is going mad

@kbknapp
tests: adds tests for default values triggering conditional requirements
3e99887
@kbknapp
fix: fixes a bug where default values should have triggered a conditi…
a7a44ba 
…onal requirement but didnt

Closes #831
@kbknapp
tests: adds tests for missing conditional requirements in usage strin…
196f666 
…g of errors
@kbknapp
fix: fixes a bug where conditionally required args werent appearing i…
94c6d31 
…n errors
@kbknapp
tests: adds tests for completion generators
0a77bb9
@kbknapp
tests: adds tests for completions with binaries names that have under…
09a6c0a 
…scores
@kbknapp
fix: fixes a bug where ZSH completions would panic if the binary name…
891a2a0 
… had an underscore in it

Closes #581
@kbknapp
fix: fixes bash completions for commands that have an underscore in t…
7f5cfa7 
…he name

Closes #581
@kbknapp
chore: fix the category for crates.io
a5e4a98
@kbknapp
docs(Macros): adds a warning about changing values in Cargo.toml not …
112aea3 
…triggering a rebuild automatically

Closes #838
@kbknapp
fix(Completions): fixes a bug where global args weren't included in t…
9a1e006 
…he generated completion scripts

Closes #841
@coveralls
Copy link

coveralls commented Feb 3, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 9a1e006 on bugs-rollup into ** on master**.

@coveralls
Copy link

coveralls commented Feb 3, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 9a1e006 on bugs-rollup into ** on master**.

@coveralls
Copy link

coveralls commented Feb 3, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 9a1e006 on bugs-rollup into ** on master**.

@kbknapp kbknapp merged commit 92919f5 into master Feb 3, 2017
@kbknapp kbknapp deleted the bugs-rollup branch February 3, 2017 22:43
@coveralls
Copy link

coveralls commented Feb 3, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 6d63cf7 on bugs-rollup into ** on master**.

@nabijaczleweli
Copy link
Contributor

xD coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbknapp @coveralls @nabijaczleweli