Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop the leaks #867

Merged
merged 11 commits into from
Feb 21, 2017
Merged

Stop the leaks #867

merged 11 commits into from
Feb 21, 2017

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Feb 21, 2017

No description provided.

@kbknapp
chore: clippy run
65b12f9
@kbknapp
refactor(Arg): removes duplicate and uses Base, Switched, and Valued …
fb7057c 
…internally now
@kbknapp
api: provides default_value_os and default_value_if[s]_os
0f2a378 
One can now define default values that contain invalid UTF-8.

The underlying implementation has also been changed to use OsStrs in order to avoid duplication
of code and provide the new APIs basically for free.

Closes #849
@kbknapp
style: improves the style of doc tests and examples to increase reada…
e0f7722 
…bility and uniformity
@kbknapp
feat(Options): adds the ability to require the equals syntax with opt…
f002693 
…ions --opt=val

Closes #833
@kbknapp
tests: adds tests for requiring the equals syntax in options
a01812f
@kbknapp
chore: rustfmt run
10ca4d1
@kbknapp
fix: fixes a trait that's marked private accidentlly, but should be c…
1ae2110 
…rate internal public
@kbknapp
Merge branch 'master' into issues-833,849
6b57258
@kbknapp
fix: fixes some memory leaks when an error is detected and clap exits
8c2dd28
@kbknapp
chore: rustfmt run
588f373
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 588f373 on stop-the-leaks into ** on master**.

@kbknapp
Copy link
Member Author

kbknapp commented Feb 21, 2017

@homu r+

@homu
Copy link
Contributor

homu commented Feb 21, 2017

📌 Commit 588f373 has been approved by kbknapp

homu added a commit that referenced this pull request Feb 21, 2017
@homu
Auto merge of #867 - kbknapp:stop-the-leaks, r=kbknapp
53f3b65 
Stop the leaks
@homu homu merged commit 588f373 into master Feb 21, 2017
@homu
Copy link
Contributor

homu commented Feb 21, 2017

⚡ Test exempted - status

@homu homu mentioned this pull request Feb 21, 2017
Merged
@kbknapp kbknapp deleted the stop-the-leaks branch June 20, 2017 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbknapp @coveralls @homu