cargo: restrict unicode-segmentation to ~1.1.0 #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgeisler, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jimmycuadra, @kbknapp and @tormol to be potential reviewers. |
The newly released version 1.2.0 of unicode-segmentation adds code that use the "?" operator, which in turn requires Rust 1.13.0. However, clap currently still works with Rust 1.11.0 and this caused build failures: https://travis-ci.org/kbknapp/clap-rs/jobs/235010822 The changes since 1.1.0 seem to be related cursors/iterators and I think clap can work fine without them.
mgeisler
force-pushed
the
restrict-unicode-segmentation-version
branch
from
7ad588d
to
b05a3eb
Compare
mgeisler
changed the title
1 similar comment
|
Is there a way to get this mention bot thing to stop mentioning me? I tried blocking its account but I still got notified here. |
|
@jimmycuadra I apologise I'll set it up to only ping me or collaborators |
|
Hi @kbknapp, any change to get this merged? |
|
Apologies, I'm out of town right now so this slipped my mind. @homu r+ |
|
📌 Commit b05a3eb has been approved by |
homu
added a commit
that referenced
this pull request
May 28, 2017
…r=kbknapp cargo: restrict unicode-segmentation to ~1.1.0 Version 1.2.0 of unicode-segmentation adds code that use the "?" operator, which in turn requires Rust 1.13.0. However, clap currently still works with Rust 1.11.0 and this caused build failures: https://travis-ci.org/kbknapp/clap-rs/jobs/235010822 The changes since 1.1.0 seem to be related cursors/iterators and I think clap can work fine without them. This was found as part of #845. See also unicode-rs/unicode-segmentation#26. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kbknapp/clap-rs/967) <!-- Reviewable:end -->
|
💥 Test timed out |
|
Thanks for the approval! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.2.0 of unicode-segmentation adds code that use the "?"
operator, which in turn requires Rust 1.13.0. However, clap currently
still works with Rust 1.11.0 and this caused build failures:
https://travis-ci.org/kbknapp/clap-rs/jobs/235010822
The changes since 1.1.0 seem to be related cursors/iterators and I
think clap can work fine without them.
This was found as part of #845. See also unicode-rs/unicode-segmentation#26.
This change is