Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Clarin-PL tools to use new services page #170

Merged
merged 3 commits into from
May 31, 2024

Conversation

daawidziu
Copy link

Deleted tools definitions that are no longer maintained. Updated other tools to use new page instead of old one.

@andmor-
Copy link
Member

andmor- commented May 30, 2024

If you need check here how to run the validators locally: https://github.com/clarin-eric/switchboard-tool-registry/blob/master/.github/workflows/main.yml#L18

@daawidziu
Copy link
Author

Validation errors should be fixed now

@andmor- andmor- merged commit 49424fa into clarin-eric:master May 31, 2024
1 check passed
@andmor-
Copy link
Member

andmor- commented Jun 6, 2024

Would you like this to be propagated to production?

@daawidziu
Copy link
Author

I need to fix a few things first. As written in the README, I should be able to test my tools at https://beta-switchboard.clarin.eu/, but I can't see them there. Could you check on that?

@andmor-
Copy link
Member

andmor- commented Jun 10, 2024

Fixed. The problem was that your PR inserted a duplicated name here:
https://github.com/clarin-eric/switchboard-tool-registry/pull/170/files#diff-a42083f1e8ea68dbdba773239a7f1cb5b5d6ffe7c92e452841d497d060d6b4d5R7
and here:
https://github.com/clarin-eric/switchboard-tool-registry/pull/170/files#diff-c6a0f425e111860eecded6ca14a8485a3e0cc26aa65fc7bfddd61f4d59f442ddR7

I fixed this here:
e0c816b

Now now the tools show up as expected. But please verify that the name I changed is as you would like it to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants