ft(app): Add support for other controllers #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The ability to 'scale' exists for all controllers:
* job
* deployment
* stateful
out of which only `deployment` was currently supported. The
`kubectl` protocol to scale controllers follows the same pattern
so it is relatively easier to perform this upgrade.
* Certain attributes like:
* deploy_name
will need to be deprecated since this is now applies to all
controllers. All of the changes made were intended to be graceful
and not breaking.
* `lock_acquisition`is now scoped by the `controller`. Since the locks
are relevant only when the process is running and an upgrade will not
be attempted while it is running - it was deemed fine to make this
change.
* TODOS:
* a proper logger is required to:
* scope log messages
* maintain a certain pattern
* consider variance in verbosity.
* Add tests
* Alternative/efficient ways of getting the replica count
* local command changes needed to be tested. The only 2 interactions with the kuberenetes client are for: * current scale * scale up/ scale down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
out of which only
deploymentwas currently supported. Thekubectlprotocol to scale controllers follows the same patternso it is relatively easier to perform this upgrade.
will need to be deprecated since this is now applies to all
controllers. All of the changes made were intended to be graceful
and not breaking.
lock_acquisitionis now scoped by thecontroller. Since the locksare relevant only when the process is running and an upgrade will not
be attempted while it is running - it was deemed fine to make this
change.