CR flutter#3

clarkezone · Apr 18, 2021 · edfec62 · edfec62
1 parent 721f922
commit edfec62
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/shell/platform/windows/flutter_project_bundle.cc b/shell/platform/windows/flutter_project_bundle.cc
@@ -81,7 +81,7 @@ UniqueAotDataPtr FlutterProjectBundle::LoadAotData(
 FlutterProjectBundle::~FlutterProjectBundle() {}
 
 void FlutterProjectBundle::SetSwitches(
-    std::vector<std::string> const& switches) {
+    const std::vector<std::string>& switches) {
   engine_switches_ = switches;
 }
 

diff --git a/shell/platform/windows/flutter_project_bundle.h b/shell/platform/windows/flutter_project_bundle.h
@@ -42,7 +42,7 @@ class FlutterProjectBundle {
   const std::vector<std::string> GetSwitches();
 
   // Sets engine switches.
-  void SetSwitches(std::vector<std::string> const& switches);
+  void SetSwitches(const std::vector<std::string>& switches);
 
   // Attempts to load AOT data for this bundle. The returned data must be
   // retained until any engine instance it is passed to has been shut down.

diff --git a/shell/platform/windows/flutter_windows_engine.cc b/shell/platform/windows/flutter_windows_engine.cc
@@ -185,7 +185,7 @@ FlutterWindowsEngine::~FlutterWindowsEngine() {
 }
 
 void FlutterWindowsEngine::SetSwitches(
-    std::vector<std::string> const& switches) {
+    const std::vector<std::string>& switches) {
   project_->SetSwitches(switches);
 }
 

diff --git a/shell/platform/windows/flutter_windows_engine.h b/shell/platform/windows/flutter_windows_engine.h
@@ -75,7 +75,7 @@ class FlutterWindowsEngine {
       FlutterDesktopOnPluginRegistrarDestroyed callback);
 
   // Sets switches member to the given switches.
-  void SetSwitches(std::vector<std::string> const& switches);
+  void SetSwitches(const std::vector<std::string>& switches);
 
   FlutterDesktopMessengerRef messenger() { return messenger_.get(); }
 

diff --git a/shell/platform/windows/flutter_windows_winuwp.cc b/shell/platform/windows/flutter_windows_winuwp.cc
@@ -29,9 +29,8 @@ static flutter::FlutterWindowsEngine* EngineFromHandle(
   return reinterpret_cast<flutter::FlutterWindowsEngine*>(ref);
 }
 
-// Resturns a list of discrete arguments splitting the input using a ",".
+// Returns a list of discrete arguments splitting the input using a ",".
 std::vector<std::string> SplitCommaSeparatedString(const std::string& s) {
-  // Split by ','.
   std::vector<std::string> components;
   std::istringstream stream(s);
   std::string component;