Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ensureSpine for BitVector n as pack #2702

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Implement ensureSpine for BitVector n as pack #2702

merged 3 commits into from
Apr 9, 2024

Conversation

lmbollen
Copy link
Contributor

@lmbollen lmbollen commented Apr 5, 2024

This enables us to deal with undefined BitVectors using the currently derived ensureSpine.

To satisfy ensureSpine (errorX "Undefined BitVector") == deepErrorX "Undefined BitVector"

martijnbastiaan
martijnbastiaan requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry?

clash-prelude/src/Clash/Sized/Internal/BitVector.hs Outdated Show resolved Hide resolved
@lmbollen lmbollen force-pushed the ensure-spine-BitVector branch 2 times, most recently from a610da1 to 52d9ee9 Compare April 8, 2024 14:48
martijnbastiaan
martijnbastiaan requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requests on the xToBV stuff

clash-lib/src/Clash/Normalize/Transformations/Inline.hs Outdated Show resolved Hide resolved
clash-ghc/src-ghc/Clash/GHC/Evaluator/Primitive.hs Outdated Show resolved Hide resolved
clash-prelude/src/Clash/Sized/Internal/BitVector.hs Outdated Show resolved Hide resolved
clash-prelude/src/Clash/Sized/Internal/BitVector.hs Outdated Show resolved Hide resolved
martijnbastiaan
martijnbastiaan approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmbollen lmbollen enabled auto-merge April 9, 2024 07:13
@lmbollen lmbollen disabled auto-merge April 9, 2024 07:56
@lmbollen lmbollen enabled auto-merge April 9, 2024 07:57
@lmbollen lmbollen merged commit a26bb9e into master Apr 9, 2024
11 checks passed
@lmbollen lmbollen deleted the ensure-spine-BitVector branch April 9, 2024 09:14
@lmbollen lmbollen mentioned this pull request Aug 6, 2024
Merged
@mergify mergify bot mentioned this pull request Oct 11, 2024
Merged
christiaanb added a commit that referenced this pull request Nov 2, 2024
@christiaanb
Merge pull request #2828 from clash-lang/mergify/copy/1.8/pr-2702
738ac4c 
Implement `ensureSpine` for `BitVector n` as `pack` (copy #2702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonschoorl leonschoorl leonschoorl left review comments

@martijnbastiaan martijnbastiaan martijnbastiaan approved these changes

Assignees

@christiaanb christiaanb

Labels
backport 1.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lmbollen @leonschoorl @martijnbastiaan @christiaanb