Remove PostgreSQL support #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The templates we render had changed, but only in terms of spacing. This updates the snapshots to be fully in line with the current renders.
Before this change, we defaulted to running against PostgreSQL, but that's not what we're running in production. This changes the default database to be SQLite, to better reflect the state of production. Doing so reveals a discrepancy in how the tests run between the two systems. When we run the snapshot tests against PostgreSQL, the class methods are ordered in a way that ignored symbols, but when run with SQLite, the symbols are taken into account. Given this reflects the current state of production, this is better, so I've updated the snapshot renders.
These match the new defaults in the settings file.
This file hasn't been used for a long time.
We don't run production against PostgreSQL, so there's no point in using it in tests.
We no longer need psycopg2 because we don't use PostgreSQL any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use SQLite in production, and our makefile configured things to use SQLite too.
We're trying to move away from needing a database at all, so it makes sense to remove this unused support.
As a bonus, this cuts about 22 seconds off our CI build time.