This repository has been archived by the owner on Apr 22, 2019. It is now read-only.
Feature/avs 421 74 expand customer attributes for customer code #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 28, 2017 13:39
- Add custom customer attributes to customer code option list - Refactor queue processor to use custom attribute codes when defined and selected
- Define default value for config setting
erikhansen
suggested changes
Dec 28, 2017
Model/Config/Source/CustomerCode.php
Outdated
|
|
||
| // Retrieve all customer attributes | ||
| $customerAttributes = $this->customer->getAttributes(); | ||
| foreach($customerAttributes as $attribute){ |
There was a problem hiding this comment.
Add space after foreach
Model/Config/Source/CustomerCode.php
Outdated
| $label = $attribute->getDefaultFrontendLabel(); | ||
| if (!is_null($label) && $attribute->getIsUserDefined()) { | ||
| // Only add custom attribute codes that have a frontend label value defined | ||
| $attributesArray[$attribute->getAttributeCode()] = array( |
There was a problem hiding this comment.
Switch from array() to []
- Minor code revisions
rsisco
deleted the
feature/AVS-421_74-expand-customer-attributes-for-customer-code
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVS-421_74 - Expand Customer Code config setting to include custom customer attributes
and selected