Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Flash button doesn't work #9

Closed
clawfire opened this issue Jun 25, 2021 · 3 comments
Closed

[BUG] Flash button doesn't work #9

clawfire opened this issue Jun 25, 2021 · 3 comments
Assignees
@clawfire
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@clawfire
Copy link
Owner

Describe the bug
When scanning, the flash button is never enabled

Expected behavior
Flash button going responsive and allow to turn on/off the flashlight

Smartphone (please complete the following information):

  • Device: iPhone12
  • OS: iOS 14.6
  • Browser Safari
@clawfire clawfire added bug Something isn't working good first issue Good for newcomers labels Jun 25, 2021
@biou
Copy link
Collaborator

biou commented Jun 25, 2021

It seems that the required API is not available in Safari iOS
zxing-js/browser#12

@clawfire clawfire mentioned this issue Jun 25, 2021
Closed
@clawfire
Copy link
Owner Author

That sucks :(

@clawfire
Copy link
Owner Author

We should then have a default state "torch control unavailable" which changes to "switch torch on/off" when torch API is available I think.

@clawfire clawfire self-assigned this Jun 25, 2021
clawfire added a commit that referenced this issue Jun 25, 2021
@clawfire
Merge branch 'release/1.1'
c23a110 
* release/1.1:
  Add the first changelog
  Add deploy preview context
  Update the README to put some basic links.
  Closes #12 Add certificate type to the passbook
  Actually we should reference flashlight_btn better
  Fixes #9 : remove button if not supported
  Fixes #7 Add test data to the back of the passbook
  Wrapping console log with conditionnal display on env dev only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clawfire clawfire

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clawfire @biou