Use semaphore from the storage module #664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 28, 2019 15:07
Pull Request Test Coverage Report for Build 2342
💛 - Coveralls |
pedro-rosario
changed the title
james-owen
reviewed
May 31, 2019
| .then(() => internalBootstrap(bootstrap)) | ||
| .then(() => | ||
| db.applyLock | ||
| ? db.applyLock('bootstrap', internalBootstrap) |
There was a problem hiding this comment.
Looks good, but I'd like to get some clarity on this pattern.
There was a problem hiding this comment.
This was a suggestion to avoid breaking changes:
If the storage module has an applyLock method, we use it.
If it doesn't, we execute the bootstrap as before (using the bootstrap boolean that comes from the configuration)
pedro-rosario
added
the
8.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #606
TODO: