Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config settings to generate html cover coverage reports locally #552

Merged
merged 2 commits into from
Aug 5, 2016

Conversation

amycheng
Copy link
Contributor

@amycheng amycheng commented Aug 4, 2016

some karma config changes so that HTML code coverage reports are generated when we run npm run test-local.

HTML reports would provide more immediate feedback than using coveralls.io

@@ -22,6 +22,9 @@ settings = {
presets: ['es2015']
}),
istanbul({
instrumenterConfig: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes this bug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a comment linking to this ?

@byronhulcher
Copy link
Contributor

👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 79.874% when pulling b38c31f on local-coverage-reports into bcfe4f0 on master.

@nelsonpecora
Copy link
Contributor

Showing the coverage increases the coverage. There's something deeply philosophical about that. 👍

@amycheng amycheng merged commit a47f291 into master Aug 5, 2016
@amycheng amycheng deleted the local-coverage-reports branch August 5, 2016 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants