Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in color fallback with importance #346

Closed
kizu opened this issue Aug 26, 2014 · 1 comment
Closed

Bug in color fallback with importance #346

kizu opened this issue Aug 26, 2014 · 1 comment
Assignees
Milestone

Comments

@kizu
Copy link

kizu commented Aug 26, 2014

When you have multiple declarations with the same property, but one with the hex/keyword and another with rgb/hsl/rgba/hsla, and all of those declarations are !important, then all the rgba/… declarations are incorrectly discarded:

.test {
    color: red !important;
    color: rgba(0,255,0,0.5) !important;
}

Incorrectly minifies to this:

.test{color:red!important}

Expected:

.test{color:red!important;color:rgba(0,255,0,.5)!important}
@jakubpawlowicz
Copy link
Collaborator

Good catch!

@jakubpawlowicz jakubpawlowicz added this to the 2.2.15 milestone Aug 26, 2014
@jakubpawlowicz jakubpawlowicz self-assigned this Aug 26, 2014
jakubpawlowicz added a commit that referenced this issue Sep 14, 2014
Follow up to #346 for overriding important property by another important one in shorthand declarations.
jakubpawlowicz added a commit that referenced this issue Sep 16, 2014
Follow up to #346 for overriding important property by another important one in shorthand declarations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants